Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Bundle doesn't include package config paths (*.json files) if the absolute path contains a '(' #811

Closed
rsc1975 opened this issue Jun 11, 2017 · 2 comments

Comments

@rsc1975
Copy link

rsc1975 commented Jun 11, 2017

When I created the bundle in my linux env, the resulting js file doesn't include the *.json files (package config files). I opened a Question in StackOverflow related with this issue, where I explain some details, but the problem is quite simple, my package config paths It's something like:

  packageConfigPaths: [
    "github:*/*.json",
    "npm:@angular/*.json",
    "npm:@covalent/*.json",
    "npm:*.json"
  ],

But my base directory It was something like : "/home/tomcat/.jenkins/.../My Proyect (angular2)", so after some debug, I see that the method getPackageConfigPath(packageConfigPaths, normalized) didn't return anything for the project libs (the same config worked ok in my local env), and I think that the problem is the regExp used to see if the packagename matches in the absolute path defined by packageConfigPaths section, the '(...)' in the absolute path is affecting the regExp match method.

I think that the regExp should be applied only over the packageConfigPaths values , but not on the entire absolute path, anyway I'm not sure, maybe there is a better solution.

@guybedford
Copy link
Member

Thanks, fixed in 2315f5f for the next release.

@guybedford
Copy link
Member

Released in 0.16.7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants