We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I got confused while doing a review yesterday on #1401 because I happened to be looking at https://github.com/talonhub/community/blob/main/core/application_matches.py around the same time and we are constantly using and where I guess we don't need to. I think almost (not all) of those are redundant?
and
Also just quickly poking around elsewhere, eg https://github.com/talonhub/community/blob/main/apps/outlook/outlook_win.talon, we are using and where it isn't needed.
Probably makes sense to fix all these to not have superfluous logic, where https://talon.wiki/customization/talon-files/ is probably the best reference of the AND and OR behavior.
AND
OR
If I'm derping here still, I'm happy to be corrected :D
The text was updated successfully, but these errors were encountered:
fix: neovim app detection for windows old neovim
b9573b5
This sounds right, though we should fix the associated helpers. Probably the culprit for most of these :)
community/plugin/talon_helpers/talon_helpers.py
Line 24 in 0a4af44
Sorry, something went wrong.
No branches or pull requests
I got confused while doing a review yesterday on #1401 because I happened to be looking at https://github.com/talonhub/community/blob/main/core/application_matches.py around the same time and we are constantly using
and
where I guess we don't need to. I think almost (not all) of those are redundant?Also just quickly poking around elsewhere, eg https://github.com/talonhub/community/blob/main/apps/outlook/outlook_win.talon, we are using
and
where it isn't needed.Probably makes sense to fix all these to not have superfluous logic, where https://talon.wiki/customization/talon-files/ is probably the best reference of the
AND
andOR
behavior.If I'm derping here still, I'm happy to be corrected :D
The text was updated successfully, but these errors were encountered: