Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving to esm and then build for cjs #414

Open
renhiyama opened this issue Jul 7, 2023 · 2 comments
Open

Consider moving to esm and then build for cjs #414

renhiyama opened this issue Jul 7, 2023 · 2 comments

Comments

@renhiyama
Copy link

Before submitting an issue, please, see https://github.com/tapio/live-server#troubleshooting

Issue description

As stated in title; because https://esm.sh can't build it properly as __dirname isn't implemented in esm so it makes it impossible for it to properly work. If you don't consider moving to esm, atleast consider putting injection.html as a string, save it to a js file as a string and export it, and then import it. Same for other files. This would fix it :)

Software details

  • Command line used for launching live-server:
  • OS:
  • Browser (if browser related):
  • Node.js version:
  • live-server version:
@Axellarator
Copy link

This runs

import liveServer from 'live-server'

var params = {
	port: 8080,
	host: "0.0.0.0",
	root: "./www",
	open: true,
	ignore: './src',
	file: "index.html",
	wait: 1000,
	mount: [['./scripts', './node_modules']], // Mount a directory to a route.
	logLevel: 2, // 0 = errors only, 1 = some, 2 = lots
	middleware: [function(req, res, next) { next(); }] // Takes an array of Connect-compatible middleware that are injected into the server middleware stack
};
liveServer.start(params);

@renhiyama
Copy link
Author

This runs

import liveServer from 'live-server'

var params = {
	port: 8080,
	host: "0.0.0.0",
	root: "./www",
	open: true,
	ignore: './src',
	file: "index.html",
	wait: 1000,
	mount: [['./scripts', './node_modules']], // Mount a directory to a route.
	logLevel: 2, // 0 = errors only, 1 = some, 2 = lots
	middleware: [function(req, res, next) { next(); }] // Takes an array of Connect-compatible middleware that are injected into the server middleware stack
};
liveServer.start(params);

That's because of how nodejs works. I want use it via URL imports sooo ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants