Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Autoupdate of Start and End Dates in Override Form #3456

Closed
mastercactapus opened this issue Nov 15, 2023 · 1 comment · Fixed by #3474
Closed

Incorrect Autoupdate of Start and End Dates in Override Form #3456

mastercactapus opened this issue Nov 15, 2023 · 1 comment · Fixed by #3474
Labels
bug Something isn't working

Comments

@mastercactapus
Copy link
Member

Describe the Bug:
Changing the day input in the "Start" or "End" time fields in the Override form automatically updates the other respective field. This makes changing the exact date and time for a future schedule nearly impossible via typing in numbers.

Steps to Reproduce:

  1. Go to an existing schedule.
  2. Click "Override".
  3. Click "Cover Someone's Shifts".
  4. Click on the Day in the "Start" or "End" time input fields.
  5. Change the Day via keyboard input (E.g. input "15" for the 15th).
  6. Observe that the other date changes.
  • If you change Start, then the End time changes.
  • If you change End, then the Start time changes.

Expected Behavior:
The day input for "Start" or "End" time field should be able to be changed independently, without automatically updating the other field.

Observed Behavior:
Changing the start or end day leads to the automatic update of the other respective field, making it difficult to set a specific future date/time.

Application Version:
This issue is seen across all versions of GoAlert.

Desktop/Browser:
This issue has been reproduced across all browsers.

Additional Context
Possibly related to, or compounded by: #3426

@mastercactapus mastercactapus added the bug Something isn't working label Nov 15, 2023
@Forfold
Copy link
Contributor

Forfold commented Nov 15, 2023

Via typing is a duplicate of #3426, however, there is also the issue of the date picker -> when selecting a month in the future (with the intention of setting the date backward) results in the end being updated without the user wanting.

E.g.

  1. Start: 11/15, End: 12/14
  2. Open Start's date picker. Move forward one month (bug happens here)
  3. Click on a date in December before 12/14
  4. Close date picker
  5. See that the end date has been moved to 1/16 (should not have changed)

Removing the client-side validation will fix both use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants