-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Strange socket name and compatibility with firejail #16349
Comments
english only plz. |
tdesktop IPC, used for single instance implementation |
What prevents it from being called TelegramDesktop or telegram-desktop or telegram.desktop? |
tdesktop can have multiple instances if you specify a different profile directory |
telegram-desktop-1 This would allow a universal rule to be written like this |
How do you imagine multiple processes will find the right socket? |
A socket with that name it somehow finds. |
Currently it uses a hash of path to the profile directory. I don't think complicating the logic and going through all the sockets with PIDs is something that should be done.
|
1 {} Bad symbols |
I don't honestly know, only @john-preston knows that. It's named like
From what I see, it can be different between different builds (installation sources), but it shouldn't change until you change installation source.
Ask the author of the rules. Probably they should comment them. |
So this option is not good for the universal rule. |
You can't do universal rule for all the builds. Even with your variant they would need a way to differentiate and you still won't be able to create an universal rule.
Maximum path length (including file name) for socket on *nix is 108 bytes, no, thanks. |
For the reason I described (dynamic socket name without static directory name) or some other?
/run/user/1000/telegram-desktop/d937f37639c4916b9e587fdf17f18985-{87A94AB0-E370-4cde-98D3-ACC110C5967D} (103 < 108) Well you or your colleagues themselves gave such a long and uninformative name. |
It's not like that for everyone. flatpak and snap add their subdirectories to the path. The path can point to $HOME/.cache in some scenarios (e.g. non-systemd distros). Not to mention that UID can have more numbers. |
Sorry, but I don't think any change is needed here. Just use GUID, it should fit your needs. |
Well, then all the more reason to do something with it (with the name of the socket), you have created yourself a time bomb and do not see it and think that everything is fine and there are no problems and do not need to do anything. |
@Aokromes can you close the issue since the question is answered? |
If I launch telegram-desktop via firejail from any browser (firefox, chromium) via firejail (previously enabling dbus), a problem appears, the 2nd instance is launched.
This is due to the directive
include whitelist-runuser-common.inc
in the browsers profile.The contents of this file.
It would seem that one should simply ask the firejail developer to add something to this list
whitelist ${RUNUSER}/telegram-desktop
But the socket name isn't
telegram-desktop
at all, but some ugly windows registry-styled937f37639639c4916b9e587fdf17f18985-{87A94AB0-E370-4cde-98D3-ACC110C5967D}
.Everyone else in
/run/user/1000/
has nice, short and clear names everywhere but this one.Why is it like that?
How is it formed?
Is it always like this for everybody, or it depends on something?
P.S. I did not immediately determine that this is a bug, maybe I do not understand something?
The text was updated successfully, but these errors were encountered: