Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two large or wrongly positioned message on landscape iPad app with iOS 8 #73

Closed
gtennis opened this issue Apr 12, 2015 · 7 comments
Closed

Comments

@gtennis
Copy link

gtennis commented Apr 12, 2015

Message is shown of full screen iPad portrait size on iPad landscape app with iOS 8. Tried with iPad 2 (iOS 8) simulator. Success message type. I didn't find any info about it being not supported for iPad, therefore wondering has anybody tried it to use on iPad?

@gtennis
Copy link
Author

gtennis commented Apr 12, 2015

Now it works. Used @ivanharmat suggested fix: #59

@gtennis gtennis closed this as completed Apr 12, 2015
@gtennis gtennis reopened this Apr 12, 2015
@gtennis
Copy link
Author

gtennis commented Apr 12, 2015

It would be nice this fix to be merged into regular branch. Otherwise it will be overwritten next time we perform pod install. Usually I'm using dynamic pod versions therefore I need to add this change somewhere else. Tried to subclass TWMessageView and override method but TWMessageView is declared in manager class implementation therefore there no access to it.

@terryworona
Copy link
Owner

@centurionas you want to submit a PR for this fix?

@terryworona
Copy link
Owner

Pulled in this manually via commit: 581a116

@gtennis
Copy link
Author

gtennis commented Apr 15, 2015

Thanks @terryworona for excellent library. Now it works. Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

@cdzombak
Copy link

Though I'm wondering why it's showing 1.7.2 version in cocoa pods and my pods file contains "pod 'TWMessageBarManager', '~> 1.7'". But when I run pod install it's written "Installing TWMessageBarManager 1.7.0 (was 1.7.0)". Should it be saying "1.7.2" when installing pod?

What's in your Podfile.lock? If you have previously installed 1.7.0, pod install won't update it for you—either change your Podfile to require pod 'TWMessageBarManager', '~> 1.7.2' or run pod update.

@terryworona
Copy link
Owner

@centurionas - change your podfile to:

pod 'TWMessageBarManager'

or

pod 'TWMessageBarManager', '~> 1.7.2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants