Replies: 8 comments
-
Yep, this is a good idea, I think we should create a Container interface with the current functions we implemented in the container like: type Container interface{
Terminate(ctx context.Context, t *testing.T) error
LivenessCheckPorts(ctx context.Context) (nat.PortSet, error)
GetIPAddress(ctx context.Context) (string, error)
GetHostEndpoint(ctx context.Context, port string) (string, string, error)
} And we can have a new file Nice idea! I don't think this is a top priority btw. For example, I am using this library in a project and we use Jenkins to run tests against kubernetes but we use Docker in Docker. I am not sure about the benefits of having the ability to run pods directly. What do you think? |
Beta Was this translation helpful? Give feedback.
-
That sounds great! |
Beta Was this translation helpful? Give feedback.
-
The foundation for this has been laid in #36 |
Beta Was this translation helpful? Give feedback.
-
This is probably something we should do with the Java implementation and other forks, at the right time. Please could we discuss the general approach to tackling this? I can't think of anything specific, but it would be good for all the implementations to be gradually moving towards convergence on feature sets rather than divergence 😄 . |
Beta Was this translation helpful? Give feedback.
-
We have a lot to fix before this. So yes! Let's work on this together when
everyone will be ready.
…On Mon, Nov 26, 2018, 22:03 Richard North ***@***.*** wrote:
This is probably something we should do with the Java implementation and
other forks, at the right time. Please could we discuss the general
approach to tackling this?
I can't think of anything specific, but it would be good for all the
implementations to be gradually moving towards convergence on feature sets
rather than divergence 😄 .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABjgO2fZEjzfh7eycZhEmDk9WlEJcSX6ks5uzFcPgaJpZM4Yv8cC>
.
|
Beta Was this translation helpful? Give feedback.
-
I think it makes sense to move this thread to Discussions |
Beta Was this translation helpful? Give feedback.
-
Hey, not sure if this still 'a thing' but could you probably elaborate how you imagine the workflow or what could be the benefit?
I'm just wondering because the former approach could be done rather easy and could be really helpful because Docker-in-Docker is no fun in Kubernetes 😄 but the latter approach could be rather hard because there are so many different deployment mechanisms and what about CRDs and stuff...? |
Beta Was this translation helpful? Give feedback.
-
A lot of the reasons why we think that k8s integration as envisioned in most cases does not really make sense for the concept of Testcontainers have been outlined in this issue in the |
Beta Was this translation helpful? Give feedback.
-
Someone at a meetup lately suggested it would be cool to be able to start containers on Kubernetes so blackbox tests of containers can be done using standard test libraries.
Since this library is in an early state, it would be a great opportunity to abstract the container layer in such a way that it does not matter whether the Docker or Kubernetes APIs are used.
Beta Was this translation helpful? Give feedback.
All reactions