-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of docker.sock path #399
Comments
I've seen other examples that suggest using |
Right now we do not implement that but it will be great to cod something that behave like tc-java does |
PR: #407 |
In my case I try to use As @austince I'm looking for a way to disable Ryuk through Any fork for this? Thank you, EDIT: I looked a bit more at the code and doing a PR for this is a bit annoying because which would prevail if both are set? Considering In the meantime since my CI/CD had an environment variable |
@sneko what do you think if we start a discussion on how to redesign this part of the code, supporting a property/env-var to disable Ryuk at the configuration level (probably overridden at the containerRequest level)? |
I moved the settings configuration to a discussion (#531) I'm closing this issue, as the docker sock path it's now configurable, thanks! |
Feature Request
I would like that the library understands an envbironment variable
TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE
and uses this when starting the reaper container (ryuk
)I'll try to contribute some code when I have some spare time
Something like this (using pseudo code on the change section):
on
testcontainers-go/reaper.go
Lines 58 to 69 in 9c3076f
Motivation
Context
Following the announcement that Docker Desktop is not free anymore some users started using different tools to manage and their containers.
In some workaround scenarios the socket
docker.sock
is created in non-standard locations.It's easy to setup the
DOCKER_HOST
environment variable and most applications that use the Docker API will run just fine.But in
testcontainers-go
the reaper container,ryuk
is set-up to use the standard location.Some tutorials [#1], [#2] suggest setting up the environment variable
TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE
, but according to my research, onlytestcontainers-java
andtestcontainers-node
make use of these variables.Example
Mac users, for instance, can use
lima-vm/lima
and install docker inside a virtual machine.Most tutorials and sample config files create the socket on
/run/user/502/docker.sock
on the guest vm and a symlink at$HOME/docker.sock
on the host computer.The text was updated successfully, but these errors were encountered: