-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate modules for metrics and tracing wrappers #2
Comments
Agree, there is a simpler idea, though: Just abstract away the metrics and opentracing as much as possible - but maybe overkill. |
OpenTracing has been deprecated for nearly a year; why wouldn't you just switch to OpenTelemetry? There is a bridge for anyone who needs OpenTracing. |
I agree I wouldn’t want yet another abstraction, but for me it was important people choose to adopt the dependency, not us force it onto people. |
Maybe if you include "no dependency" as an option that becomes clearer? |
I'm not exactly sure what you're proposing. |
The specific libraries and mechanisms used for metrics and tracing can be quite opinionated and a library meant as an abstraction for object storage providers should not force a dependency of one or the other system onto downstream users. As such I think that the:
Should be served by separate modules.
The text was updated successfully, but these errors were encountered: