Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a plan to remove the thanos- prefix from the user agent? #87

Open
ohkinozomu opened this issue Nov 13, 2023 · 1 comment · May be fixed by #88
Open

Is there a plan to remove the thanos- prefix from the user agent? #87

ohkinozomu opened this issue Nov 13, 2023 · 1 comment · May be fixed by #88

Comments

@ohkinozomu
Copy link

Some providers are currently adding a thanos- prefix to the user agent.

option.WithUserAgent(fmt.Sprintf("thanos-%s/%s (%s)", component, version.Version, runtime.Version())),

client.Config.UserAgent = fmt.Sprintf("thanos-%s", component)

client.SetAppInfo(fmt.Sprintf("thanos-%s", component), fmt.Sprintf("%s (%s)", version.Version, runtime.Version()))

Is there a plan to remove this?

Related issue: #23

@metalmatze
Copy link
Contributor

I haven't heard anything about it. I also think you're the first person to ask.
I'm fine with removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants