From f957172023b6fcd4dc570be47f5f70469f65fba5 Mon Sep 17 00:00:00 2001 From: Seena Fallah Date: Wed, 21 Dec 2022 16:52:05 +0100 Subject: [PATCH] compact: remove cancel on SyncMetas errors (#5923) in a favour of 86b4039948b0918ca2ba121637d1d0d5b3f768c0 SyncMetas will retry if it's retriable. Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated, the ones not and are not retriable will throw an interrupt to run.Group() by returning err and Group will call cancel() as it's configured for its interrupt func. Signed-off-by: Seena Fallah Signed-off-by: Seena Fallah --- cmd/thanos/compact.go | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/thanos/compact.go b/cmd/thanos/compact.go index 6cb4eae3e9..94384fa2da 100644 --- a/cmd/thanos/compact.go +++ b/cmd/thanos/compact.go @@ -406,7 +406,6 @@ func runCompact( defer cleanMtx.Unlock() if err := sy.SyncMetas(ctx); err != nil { - cancel() return errors.Wrap(err, "syncing metas") }