Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readnessProbe checks failed of thanos bucket web #2115

Closed
wujie1993 opened this issue Feb 10, 2020 · 2 comments · Fixed by #2120
Closed

readnessProbe checks failed of thanos bucket web #2115

wujie1993 opened this issue Feb 10, 2020 · 2 comments · Fixed by #2120

Comments

@wujie1993
Copy link

wujie1993 commented Feb 10, 2020

Thanos, Prometheus and Golang version used:

thanos: 0.10.1
prometheus: 2.7.1
golang: 1.13.6

Object Storage Provider:

minio

What happened:

readnessProbe checks failed of thanos bucket web.

missing statusProber.Ready() after start bucket web

What you expected to happen:

running bucket web and curl /-/ready should return 200 ok.

How to reproduce it (as minimally and precisely as possible):

running bucket web and curl /-/ready return 503 error.

Full logs to relevant components:

Logs

level=info ts=2020-02-10T03:46:27.265300556Z caller=main.go:149 msg="Tracing will be disabled"
level=info ts=2020-02-10T03:46:27.266072914Z caller=factory.go:43 msg="loading bucket configuration"
level=info ts=2020-02-10T03:46:27.266886883Z caller=bucket.go:410 msg="synchronizing block metadata"
level=info ts=2020-02-10T03:46:27.268086808Z caller=prober.go:127 msg="changing probe status" status=healthy
level=info ts=2020-02-10T03:46:27.268113295Z caller=http.go:53 service=http/server component=bucket msg="listening for requests and metrics" address=0.0.0.0:10902
level=info ts=2020-02-10T03:46:27.358101897Z caller=bucket.go:430 msg="downloaded blocks meta.json" num=6

Anything else we need to know:

@yeya24
Copy link
Contributor

yeya24 commented Feb 10, 2020

Thanks for your report! Yes, I think we miss the statusProber.Ready() here.
@kakkoyun Could you please take a look?

@kakkoyun
Copy link
Member

Of course. @yeya24 feel free to assign it to me, I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants