Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for exemplars API #4014

Closed
yeya24 opened this issue Apr 3, 2021 · 2 comments · Fixed by #4221
Closed

Add E2E test for exemplars API #4014

yeya24 opened this issue Apr 3, 2021 · 2 comments · Fixed by #4221

Comments

@yeya24
Copy link
Contributor

yeya24 commented Apr 3, 2021

Now the exemplars API is added and we already instrumented Thanos with exemplars in #3977. It is time to add an E2E test case for it.

AC:
1. Add a Jaeger all in one service in the E2E test as it is required for tracing
2. Update the options to start Thanos component with tracing configs
3. Call the exemplars API from thanos querier and check the results

For the request and response of the exemplars API, please check https://prometheus.io/docs/prometheus/latest/querying/api/#querying-exemplars

@yeya24
Copy link
Contributor Author

yeya24 commented Apr 12, 2021

This test case itself should be easy to implement. However, we might be blocked by another test case TestRulesAPI_Fanout.
This is mentioned https://github.com/thanos-io/thanos/pull/3905/files#r591791448.
The latest version Prometheus has strict unmarshalling so we need to fix this test case first.

@yeya24
Copy link
Contributor Author

yeya24 commented May 11, 2021

Assign this to myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant