Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact: Retention progress metrics #4835

Closed
yeya24 opened this issue Nov 6, 2021 · 0 comments · Fixed by #4848
Closed

Compact: Retention progress metrics #4835

yeya24 opened this issue Nov 6, 2021 · 0 comments · Fixed by #4848
Labels
component: compact difficulty: medium help wanted

Comments

@yeya24
Copy link
Contributor

yeya24 commented Nov 6, 2021

Is your proposal related to a problem?

Because retention happens after compaction and downsampling, so it might get huge retention backlog to do in the object storage. We also got the same problem mentioned in #4406.

It would be great to have a way to tell how many blocks are beyond their retention period but don't get deleted.

Describe the solution you'd like

We have introduced the progress calculator to get compaction and downsampling progress as metrics in #4801.

We can implement another RetentionProgressCalculator to do this work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: compact difficulty: medium help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compactor: Add metrics for retention progress metonymic-smokey/thanos
1 participant
@yeya24