Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-helm: Bring sample up to date with latest prometheus helm chart #6301

Closed
rubenvw-ngdata opened this issue Apr 20, 2023 · 6 comments · Fixed by #7132
Closed

kubernetes-helm: Bring sample up to date with latest prometheus helm chart #6301

rubenvw-ngdata opened this issue Apr 20, 2023 · 6 comments · Fixed by #7132

Comments

@rubenvw-ngdata
Copy link

Thanos, Prometheus and Golang version used: Thanos v0.31.0 Prometheus helm chart v 20.0.2

Object Storage Provider: NA

What happened:

The sidecar configuration for the official prometheus helm chart is not up to date (https://github.com/thanos-io/thanos/tree/main/tutorials/kubernetes-helm):

  • It doesn't know that configmapReload can be simply disabled
  • it doesn't describe the solution for the alert manager.
  • sidecarContainers is no longer an array
  • even after doing the changes to fix the above, it fails mounting the new volumes and secrets.

What you expected to happen:

To find a working configuration with the latest prometheus chart version.

How to reproduce it (as minimally and precisely as possible): Try to run the configuration from the docs

Full logs to relevant components: NA

Anything else we need to know: NA

@matej-g
Copy link
Collaborator

matej-g commented Apr 25, 2023

Thanks for flagging this @rubenvw-ngdata, if you'd be up to working on this let me know 🙂

@rubenvw-ngdata
Copy link
Author

@matej-g So far I haven't got it working yet. If I get it working, I can share the configuration.

@TheSwarnim
Copy link

Hi @matej-g, can I pick this task

@matej-g
Copy link
Collaborator

matej-g commented May 11, 2023

@TheSwarnim Go for it!

@rubenvw-ngdata
Copy link
Author

Hi @TheSwarnim, is there any progress on this?

@ashutosh887
Copy link

I would like to work on this now @rubenvw-ngdata Sir

Please assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants