Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: use generated GraphQL types everywhere #76

Open
veksen opened this issue Aug 23, 2019 · 0 comments
Open

Types: use generated GraphQL types everywhere #76

veksen opened this issue Aug 23, 2019 · 0 comments
Labels
effort:low Few minutes to an hour flag:good first issue Good for newcomers flag:help wanted Extra attention is needed priority:low Not a high level of importance scope:dev Needs dev work type:refactoring Rework/move code

Comments

@veksen
Copy link
Collaborator

veksen commented Aug 23, 2019

We've implemented generated types from the GraphQL endpoint, but they are not used everywhere:

example of implementation:

function RulesPage({ data }: ComponentQuery<{ md: MarkdownRemark }>) {

example where it's missing:

interface IResourceHeaderProps {
relativePath: any
title: any
authors: any
createdAt: any
timeToRead: any
recommendedReading: any
externalResources: any
}

@veksen veksen added effort:low Few minutes to an hour flag:good first issue Good for newcomers flag:help wanted Extra attention is needed scope:dev Needs dev work type:refactoring Rework/move code labels Aug 23, 2019
@veksen veksen added the priority:low Not a high level of importance label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Few minutes to an hour flag:good first issue Good for newcomers flag:help wanted Extra attention is needed priority:low Not a high level of importance scope:dev Needs dev work type:refactoring Rework/move code
Projects
None yet
Development

No branches or pull requests

2 participants