-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Don't trigger element insertion when focused inside a text field / inside custom CSS #7
Comments
Hello @jrmyfranck, I confirm this behaviour with the defaults shortcuts. I'll look for a way to avoid triggering depending on the context. In the mean time, maybe shortcuts like |
That's what I ended up doing, and it does work as a workaround. However if Structeezy was context-aware that would obviously be better. Not sure at all whether it is feasible, but I'm sharing this in case it's helpful at all: |
I think I have this one solved also. Feedback from users will tell if it is OK. It was a bit tricky because Bricks uses |
Hello @jrmyfranck, Did you have a chance to upgrade to the latest version and check if the problem is solved for you? Thanks. |
Hey @cbontems, haven't had the chance to thoroughly test it yet (been busy with non-Bricks related projects). I‘ll try to get to it during the weekend, and will report back. |
@cbontems working now when editing text. However, I noticed this behaviour when focused inside one of Bricks fields in the Styles panel (ie. when adding a class, or adding a value for a CSS property):
I don't know if that’s intentional (and I don’t necessarily think it's a bad thing), but I wanted to let you know. |
@jrmyfranck yes, I noticed this case too. They are different context, therefore not caught as the insertion one. I think it would be better to prevent shortcuts in all contexts, so I will change the behavior. |
Contact Details
hello@jrmyfranck.com
What happened?
Currently, Structeezy shortcuts fire the corresponding insertions regardless of context.
While handy to quickly add elements to the page, it can trigger unwanted insertions.
It's especially problematic with the default shortcuts, when trying to add custom CSS to an element on a mac:
%root%
"{
", but this requires me to press the "alt
" and "(
" keys (for context, the open parenthesis key ((
) is also the5
key<h5>
element to the pagePotentially the same issues could occur when trying to type a "œ", "æ", etc., ie. in a text field
Version
v0.4.0
Version
v1.9.1.1
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: