Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing "src" and "dst" configuration #41

Open
sontags opened this issue Jan 28, 2016 · 1 comment
Open

Confusing "src" and "dst" configuration #41

sontags opened this issue Jan 28, 2016 · 1 comment

Comments

@sontags
Copy link

sontags commented Jan 28, 2016

I had a confusing moment regarding this config:

{
  "port": 3001,
  "storage": {
    "src": {
      "type": "http+fs", "base_url": "http://static.stxt.media.int", "location": "/data/picfit/"
    },
    "dst": {
      "type": "fs", "location": "/data/picfit/"
    }
  },
  "kvstore": {
    "type": "cache"
  }
}

In fact dst.location is redundant with src.location since the location part of src basically describes the dst path in case of type:http+fs. Still dst is required in order not to get panics with kvstore.type:cache for cached images.

However, source should be defined in src, destination in dst:

{
  "port": 3001,
  "storage": {
    "src": {
      "type": "http", "base_url": "http://static.stxt.media.int"
    },
    "dst": {
      "type": "fs", "location": "/data/picfit/"
    }
  },
  "kvstore": {
    "type": "cache"
  }
}

BTW: This would obviously break old configs. If you consider this 'proposal' despite of that fact, I could try to provide a PR... let me know.

@tobya
Copy link

tobya commented Mar 29, 2018

this confusion may explain my issue #90

@thoas thoas mentioned this issue May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants