Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setprecision!(f::CompletionMap) #1509

Open
simonbrandhorst opened this issue May 14, 2024 · 4 comments
Open

setprecision!(f::CompletionMap) #1509

simonbrandhorst opened this issue May 14, 2024 · 4 comments
Labels

Comments

@simonbrandhorst
Copy link
Collaborator

julia> K,toK = completion(F, 2*OF);

julia> F,_ = cyclotomic_field(3)
(Cyclotomic field of order 3, z_3)

julia> OF = maximal_order(F);

julia> K,toK = completion(F, 2*OF);

julia> setprecision!(toK,5)

it seems buggy also for the other methods in the same file

By the way, I found it surprising that the completion map can have a different precision than its codomain.

@joschmitt
Copy link
Collaborator

(That is also one of the questions I have in #1500.)

@simonbrandhorst
Copy link
Collaborator Author

For the record, another bug in the ramified case:

  Qx, x = QQ["x"];
  f = x^9 - 828*x^7 - 4371*x^6 + 226071*x^5 + 2371023*x^4 - 14243253*x^3 - 318645900*x^2 - 1637156439*x - 2754662093;

  K, a = number_field(f, "a");
  OK = maximal_order(K);
  p = 3;
  P = prime_ideals_over(OK, p)[1];
  C, mC = completion(K, P, 8);


  setprecision!(mC, 20)
  setprecision!(mC, 21)
  setprecision!(mC, 20) #throws

@joschmitt
Copy link
Collaborator

Looks like there is an assert that effectively prevents one from setting the precision back to an earlier value.
I also just realized that the field .precision of the map is never updated, although it is used in the setprecision! function.

@thofma These setprecision! methods need to be revised. I could try to understand what they are supposed to be doing. Or is this written down somewhere?

@thofma
Copy link
Owner

thofma commented May 17, 2024

@fieker we forgot (did not have time) to discuss this. What is up with this @assert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants