-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visibility changes the cache hash #2978
Labels
Comments
izissise
changed the title
visibility part of the cache hash
visibility changes the cache hash
Nov 26, 2023
Ah yeah, this sucks. I think this is a little awkward to change unfortunately. I think this is a hacky way to trigger the visibility check, as we don't do it on a normal parse. Definitely room for improvement here, but seems quite low priority for us right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
It would be nice if visibility argument doesn't change the cache hash of a rule, this would speed up relaunch of please after the a visibility error.
Usually a visibility error is thrown after that the rule with an incorrect visibility is build, for some rules it takes quite a bit of time and all that works could be kept if the cache hash not change when the visibility is updated.
Thanks,
Hugues
The text was updated successfully, but these errors were encountered: