-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the modified embedded feedfinder and merge it into feedfinder2 #8
Comments
I would like to work on the issue. How do I start? |
Hello, This task is zbout contributing back the changes I made to the original feedfinder (http://www.aaronsw.com/2002/feedfinder/) to a github project that intends to revive it: https://github.com/dfm/feedfinder2 I have currently a copied and modified version of feed finder in wateronmars' sources: https://github.com/tibonihoo/wateronmars/blob/master/wom_river/utils/feedfinder.py A way to start is to remove this file and replace it with feedfinder2's sources and make sure wateronmars works again (by adapting imports and possibly edit feedfinder2 sources). The next step would be to contribute the changes made to feedfinder2's sources to the feedfinder2' project repo. Ultimately there shouldn't be any feedfinder-related sources in wateronmars, and feedfinder2 should just be a new requirement set in the requirement.txt file. |
Hi, I would like to take a shot on this if no one else currently is. |
Hi, nobody has taken it and it would be a nice contribution to the larger python community, so you are very welcome to work on it as you like ! |
Hi @tibonihoo, I have been reviewing your code trying my best to understand the task that needs to be completed but I seem to be at a roadblock. Could you explain what you mean by "sources"? And for clarification, you would like to have feedfinder2.py be used instead of feedfinder.py because not only is feedfinder2.py using python 3 but it is more recently updated? I apologize if my questions sound really basic. Any kind of direction would be really helpful as I'm more or less in the early stages of learning to program. |
feedfinder2 is at: https://github.com/dfm/feedfinder2
The text was updated successfully, but these errors were encountered: