Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: pass Mutation and RegionStore by Arc pointer #321

Open
Little-Wallace opened this issue Nov 13, 2021 · 0 comments
Open

Proposal: pass Mutation and RegionStore by Arc pointer #321

Little-Wallace opened this issue Nov 13, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@Little-Wallace
Copy link
Contributor

Problem

Client-rust costs a lot of CPU to copy the structure. And most of this copy and allocation is to copy mutation between TransactionClient and kinds of PlanBuilder.

Solution

I think we can store these Mutation and RegionStore of RegionCache as an Arc Pointer. We only need to clone them before we really call gRPC API to send requests.
@Little-Wallace Little-Wallace added the enhancement New feature or request label Nov 13, 2021
@ekexium ekexium added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Little-Wallace @ekexium