Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should use Makefile targets, to ensure these are tested #292

Open
kiancross opened this issue Jun 30, 2023 · 0 comments
Open

CI should use Makefile targets, to ensure these are tested #292

kiancross opened this issue Jun 30, 2023 · 0 comments
Labels
Enhancement New feature or request

Comments

@kiancross
Copy link
Collaborator

Describe the problem

Currently, the CI workflows do not use the Makefile install target, as they need to pass the --no-interaction option. This causes problems, as seen in #270.

Describe the solution

Use the make install target, and check in the Makefile is being called from CI.

Alternatives considered

None.
@kiancross kiancross added the Enhancement New feature or request label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kiancross