Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Config.cleanupWikifierOutput = true;" is ineffective withing a "div" #208

Open
selden opened this issue Jan 17, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@selden
Copy link

selden commented Jan 17, 2023

"Config.cleanupWikifierOutput = true;" results in an inappropriate increase in the vertical spacing between paragraphs and between lists within a "div". Paragraph indentation also changes within that "div". Apparently the cleanup doesn't happen within a "div". I see no mention of this cleanup limitation in SugarCube's documentation

To Reproduce:
Steps to reproduce the behavior:

  1. specify Config.cleanupWikifierOutput = true; within a script passage
  2. specify .passage p { text-indent: 3.0em; } within a stylesheet passage
  3. surround paragraphs and lists by div tags in a normal passage

Expected behavior.
Paragraphs should be indented
lists should be separated by only a single blank line.

Screenshots.

test_div

Project details.

  • SugarCube Version: 2.36.1
  • Included Add-ons: None
  • Included Libraries: None
  • Compiler & Version: Twine 2.5.1 and Tweego 2.1.1

Desktop details.

  • OS & Version: Windows 10 Pro 22H2 19045.2486 (64 bit)
  • Browser & Version Firefox 108 and 109 (64 bit) and Edge 108 and 109 (64 bit)

Additional context.
The zip below includes the twee and html necessary to reproduce this problem.

test_div.zip

@selden selden added the bug Something isn't working label Jan 17, 2023
@selden
Copy link
Author

selden commented Jan 17, 2023

This looks like it might be related to issue #189.

Are there still plans for a v3 of SugarCube? I'm sure there are quite a few people who'd be glad to alpha-test it for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant