If bin dir does not exists composer install/update failed

[mfuehrer82]

Expected behavior

• Create bin dir if it does not exist and install tools

Actual behavior

• Installation failed with
  [ErrorException] scandir(/app/path/bin): failed to open dir: No such file or directory

Steps to reproduce actual behavior

• Delete bin dir and run composer update
• Error occured into $this->removeFromDir()

Other information (e.g. version, os system, stacktraces, etc)

• tooly version 1.2.3

[tommy-muehle]

Good catch @mfuehrer82. Thank you. I had a condition to do this. But the "createDirectory" Method was originally created for files. So dirname() was called inside. And the result was that only the parent directory was checked if it existing.

I fixed it and release a new version 1.2.4 to solve this issue.

[mfuehrer82]

Hey,
thanks for the fast reply. But i think that did not solve the problem i had. I had an error in the removeFromDir method. I add a fix into my fork and also add a test for it. Please give me some feedback what you think about.

[tommy-muehle]

Hi,
have you updated your fork? And the "removeFromDir" method calls are part of the "cleanUp" method in which the condition still exist a few lines before.

if (false === is_dir($composerBinDirectory)) {
    $this->helper->getFilesystem()->createDirectory($composerBinDirectory);
}

$this->removeFromDir($composerBinDirectory);
$this->removeFromDir(...);