Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last activity at/by immediately when updating project #610

Open
maxceem opened this issue Jan 5, 2021 · 1 comment
Open

Update last activity at/by immediately when updating project #610

maxceem opened this issue Jan 5, 2021 · 1 comment

Comments

@maxceem
Copy link
Contributor

maxceem commented Jan 5, 2021

When we update project using PATCH/PUT endpoint we update updatedAt/updatedBy fields. But we don't update lastActivityAt/lastActivityBy fields immediately, they are only updated using Kafka event in a few seconds.

As a result, the response of PATCH/PUT endpoint contains outdated values for lastActivityAt/lastActivityBy which leads to the next small issue:

  • when we update project first time, these values are not updated
  • and only after the second update we get the values form the previous update

See demo video https://monosnap.com/file/pslk3R8TSFYO6MCOVKzLX5G1kazqZl

TODO:

  • update lastActivityAt/lastActivityBy fields immediately inside PATCH/PUT endpoint
  • remove updating these field on project update Kafka event
  • this field should still get updated on other Kafka events when some other related objects are updated, delay in such cases is inevitable and fine

FYI @RishiRajSahu

@RishiRajSahu
Copy link
Contributor

@maxceem agree in case of project's PATCH/PUT let's do it directly without events and let rest of the operations update the last-activity via events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants