Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return email when trying invite by email user already invited by handle #622

Open
maxceem opened this issue Feb 9, 2021 · 0 comments
Open
Labels

Comments

@maxceem
Copy link
Contributor

maxceem commented Feb 9, 2021

When we are trying to invite user by "email", when it is already invited by "handle" we get error which is correct. But error doesn't have "email" included for which the error happened:

image

Response from API looks like this. It doesn't have email, but it should have it.

{
  "success": [],
  "failed": [
    {
      "email": null,
      "message": "User with such email is already invited to this project."
    }
  ]
}

For example, if we invite user by "email" and after try to invite the same user by "handle" then we would get the correct error message with "handle" mentioned in the error:

{
  "success": [],
  "failed": [
    {
      "handle": "pshah_customer",
      "message": "User with such handle is already invited to this project."
    }
  ]
}

See that "handle" is provided so we know which invite failed and has error. We have to fix the same for email.

Note, this doesn't expose PII as we return this error response to the user who invited so they already know the email.

@maxceem maxceem added the bug label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant