Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than 100 challenges in one milestone #689

Open
maxceem opened this issue Dec 6, 2021 · 3 comments
Open

Allow more than 100 challenges in one milestone #689

maxceem opened this issue Dec 6, 2021 · 3 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 6, 2021

We have the functionality to create challenges inside milestones in Work Manager:

image

Which letter are shown inside Connect App:

image

But if we try to create more than 100 challenges in one milestone we are getting an error:

image

Are there any reasons to restrict the number of challenges in one milestone?
Could we allow creating any number of challenges in one milestone?

@vikasrohit
Copy link

vikasrohit commented Dec 6, 2021

There is no specific reason for putting 100 as limit for the number of challenges per phase (milestone). It was only to see what is the practical limit on number of challenges that we can see for a phase/milestone. We never expected more than 100 challenges per phase. We thought, it would make sense to add new phase/milestone in such cases. We can increase this limit to 200 for now or can think of eliminating this limit completely. I guess, we just wanted to limit the bad data when some one tries to flood our api with random data.

@maxceem
Copy link
Contributor Author

maxceem commented Dec 6, 2021

So far I'm not sure if we ever would come across with such a limitation on PROD. At the moment we only have this issue during automation testing. When we run test automation in WM it creates challenges in the same milestone. As in WM there is no functionality to add milestones we could not add new milestones in WM automatically.

So to make sure that test would always work we would need to remove this limitation completely. Otherwise during WM testing we would have to make actions in Connect which would not so good, as WM test would depend on changes in Conenct. So changes in Connect might brake tests in WM.

@vikasrohit
Copy link

Yep, understood. But I guess, if the apps are coupled, there tests would be coupled as well. I mean we need to create milestone first to create challenge. May be we can call projects api instead of using connect app front end, to create milestones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants