Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a more informative exception when FontFamily is missing from the Style specified in a TextBlock #74

Open
vchelaru opened this issue May 16, 2023 · 0 comments

Comments

@vchelaru
Copy link

vchelaru commented May 16, 2023

To reproduce:

  1. Create a Topten.RichTextKit.Style instance where the FontFamily is not specified
  2. Use this style to render text, using text similar to textBlock.AddText("Hello", styleWithNoFontFamilySet);
  3. Run the application to get an exception

Observe - Exception provides confusing information which does not lead the user to solve the problem.

System.InvalidOperationException: 'Exception in BuildFontRuns() with original length of 1 now 1, style run count 1, font run count 0, 

Expected - Exception should perform a null check and provide information to the user such as

System.InvalidOperationException: 'Style used to draw text includes a null FontFamily value. FontFamily must be set to a non-null, valid font'

Additional information:
This issue was referenced in conversation in another topic:
#43 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant