Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened Web TW Login after cancellation of Naive TW Login #9

Closed
woshiyezu opened this issue Dec 2, 2019 · 3 comments
Closed

Opened Web TW Login after cancellation of Naive TW Login #9

woshiyezu opened this issue Dec 2, 2019 · 3 comments

Comments

@woshiyezu
Copy link

Using TwitterKit5, showed Web TW login after cancelling Native TW login.

Expected behavior

Come back app after cancelling Native TW login.

Actual behavior

Opened Web TW Login after cancellation of Native TW Login

Steps to reproduce the behavior

Just use TwitterKit5, open Native login and then cancel login on it.

@touren
Copy link
Owner

touren commented Dec 7, 2019

Can't reproduce in the Demo app within the project.

Check the code: https://github.com/touren/twitter-kit-ios/blob/master/TwitterKit/TwitterKit/TWTRTwitter.m#L380

Make sure using similar logic in your own method: (BOOL)application:(UIApplication *)application openURL:(NSURL *)url options:(NSDictionary *)options

Ref: twitter-archive#122

@woshiyezu
Copy link
Author

Thanks. I will try it.

@fxsalazar
Copy link

I did test the DemoAPP out the box and yes, the WebView still poping up after app cancelation. I spotted an anomaly (made a PR #13); Still wondering why couldn't you reproduce the behaviour 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants