Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The signal-assignment analysis pass should not emit warnings for constrained signals #19

Open
fegge opened this issue Nov 13, 2023 · 0 comments

Comments

@fegge
Copy link
Collaborator

fegge commented Nov 13, 2023

If the assigned signal is constrained elsewhere in the circuit, it is enough to emit an informational finding.

In particular, the following should not raise a warning.

warning: Using the signal assignment operator `<--` does not constrain the assigned signal.
   ┌─ /.../file.circom:72:9
   │
72 │         m[i] <-- out[0][i];
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^ The assigned signal `m[i]` is not constrained here.
73 │         mRangeCheck[i] = Num2Bits(n);
74 │         mRangeCheck[i].in <== m[i];
   │         -------------------------- The signal `q[i]` is constrained here.
   │
   = For more details, see https://github.com/trailofbits/circomspect/blob/main/doc/analysis_passes.md#signal-assignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant