Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Could not install next-safe when nextjs version is 12. #39

Closed
1 task done
april-ctrlspire opened this issue Feb 10, 2022 · 7 comments
Closed
1 task done
Assignees
Labels
needs: triage Waiting for a contributor to triage type: bug Something isn't working

Comments

@april-ctrlspire
Copy link

april-ctrlspire commented Feb 10, 2022

Describe the bug

I just installed the latest nextjs (12.0.10) and trying to install next-safe and got error that it could not resolve dependency. Is the latest next-safe not compatible with the latest nextjs?

% npm i next-safe
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: me-mini-sites@undefined
npm ERR! Found: next@12.0.10
npm ERR! node_modules/next
npm ERR!   next@"^12.0.10" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer next@"^9.5.0 || ^10.2.1 || ^11.1.0" from next-safe@3.2.1
npm ERR! node_modules/next-safe
npm ERR!   next-safe@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/eptalampas/.npm/eresolve-report.txt for a full report.

Version

v3.x.x

Code of Conduct

  • I agree to follow this project's Code of Conduct
@april-ctrlspire april-ctrlspire added needs: triage Waiting for a contributor to triage type: bug Something isn't working labels Feb 10, 2022
@frattaro
Copy link

frattaro commented Jun 8, 2022

Github actions started hiccupping on this for me. Possibly because I recently started running against node 16 (since AWS lambdas now support node 16). Succeeds on rerun.

@kiily
Copy link
Contributor

kiily commented Jul 27, 2022

I can confirm that this is happening for me too on Next.js 12, Node.js 16. Happy to put a PR in to add Next.js 12 as a peer dependency in package.json. Any doc I can have a look at for how to test, don't think there is anything on the new version that would cause the library to break.

"peerDependencies": {
    https://github.com/vercel/next.js: "^9.5.0 || ^10.2.1 || ^11.1.0"
  },

@sladg
Copy link

sladg commented Aug 1, 2022

Hey! can we include Next12 as dependency? Failing build on Node16 in past days (no changes to versions, just started failing).

@kiily
Copy link
Contributor

kiily commented Aug 12, 2022

Added the PR as per the mention above - #45. We won't be revisiting this on our side but hopefully helps those that need it right now :)

@trezy
Copy link
Owner

trezy commented Dec 5, 2022

Fixed by #45

@trezy trezy closed this as completed Dec 5, 2022
@Cirelion
Copy link

I have this exact same problem but with Next 13.1.1. Should I open a new issue for this?

@kiily
Copy link
Contributor

kiily commented Jan 3, 2023

I know this has been closed but put the PR referenced above to address the issue @Cirelion 👍 Should work once it gets merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage Waiting for a contributor to triage type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants