ierr and serr module of origin

[tjfulle]

ierr and serr are defined in the forteuchos module. It would be convenient if, instead, they lived in their own module, independent of forteuchos. Perhaps forerrcnt? See this comment for a use case where this would be helpful.

@aprokop @sethrj

[sethrj]

Sure, I just put them in forteuchos because (to my knowledge) everything in trilinos is downstream of it. The instantiations of std_x etc. might also be good to have in there as well.

[aprokop]

The thing I don't like here is having an extra module to be included every time one of ForTrilinos modules is included. Is there a method to avoid that?

[aprokop]

This is going to be fixed by #169.

[tjfulle]

@aprokop said:

The thing I don't like here is having an extra module to be included every time one of ForTrilinos modules is included. Is there a method to avoid that?

That is already a requirement, right? For any package other than teuchos, you have to use forteuchos to get access to ierr and serr. I think #include “ForTrilinos.h” is the cleanest, and most intuitive, option. The header can include any mandatory use statements.

[aprokop]

@tjfulle I agree with you and that's why I followed your advice in the PR. I'm OK to always include ForTrilinos.h.

[aprokop]

For the most part, done in #169.