Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: Can't build MueLu with OpenMP backend when serial backend is disabled #13229

Open
mcarlson801 opened this issue Jul 12, 2024 · 6 comments
Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests

Comments

@mcarlson801
Copy link

When building MueLu with the OpenMP backend and the serial backend disabled, we ran into this error:

                 from .../Trilinos/packages/muelu/src/Utils/MueLu_AggregationExportFactory_def.hpp:60,
                 from .../packages/muelu/src/Utils/ExplicitInstantiation/ETI_MueLu_AggregationExportFactory.cpp:55:
.../Trilinos/packages/muelu/src/Graph/Containers/MueLu_LWGraphBase.hpp:117:72: error: 'Serial' is not a member of 'Kokkos'; did you mean 'Kokkos::Tools::Experimental::DeviceType::Serial'?

Do we need to have the serial backend enabled to build with OpenMP or is this a bug? Issue #1786 makes me think this is probably a bug.

@trilinos/muelu @jhux2

@mcarlson801 mcarlson801 added the type: bug The primary issue is a bug in Trilinos code or tests label Jul 12, 2024
Copy link

Automatic mention of the @trilinos/muelu team

@jhux2
Copy link
Member

jhux2 commented Jul 12, 2024

@mcarlson801 Is there a configure script in the Albany repo I can use to reproduce this?

@jewatkins
Copy link
Contributor

@jhux2 configuration is here on perlmutter: /global/cfs/cdirs/fanssie/users/rcaller/For_Jonathan

@mcarlson801
Copy link
Author

@mcarlson801 Is there a configure script in the Albany repo I can use to reproduce this?

This should be the one: https://github.com/sandialabs/Albany/blob/master/doc/LandIce/machines/perlmutter/do-cmake-trilinos-openmp-gcc

@jhux2
Copy link
Member

jhux2 commented Jul 15, 2024

This is a temporary side-effect of work to consolidate Kokkos and non-Kokkos code paths in MueLu. For the moment, the serial backend is necessary, but ultimately it won't be required. @mcarlson801 If this will pose a problem for Albany, please let me know.

@mcarlson801
Copy link
Author

This doesn't necessarily pose a problem for Albany, we can build with both enabled. We are just seeing performance similar to if we were using the serial backend (about 2x slower with half the mpi ranks) so we were just concerned that maybe the serial backend was taking precedence. @jewatkins can probably speak more on this when he's back from travel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests
Projects
Status: Backlog
Development

No branches or pull requests

3 participants