Showing empty <Label> instead of Slide Content (Angular 6)

[alereisan]

Showing empty <Label> instead of Slide Content (Angular 6)

[triniwiz]

1. Which platform
2. All slides or the first

[alereisan]

Android 9 SDK 28 and all Slides affected.

[mailiam]

also occurs on iOS 12 with N{5}
It only shows view like <Label [text]="item">

<Pager row="0" timetable
  [items]="availableTimetable.weekdays">
  <ng-template pagerItemTemplate let-i="index" let-day="item">
    <GridLayout times flexWrap="wrap"
      iosOverflowSafeArea="false">
      <StackLayout orientation="horizontal">
        <Button text="{{ '\ue080' }}"></Button>
        <Label text="{{day}}"></Label>
      </StackLayout>
      <FlexboxLayout class="part" flexWrap="wrap" 
        [width]="cardWidth" iosOverflowSafeArea="false"
        *ngFor="let part of availableTimetable.times">
        <ng-template ngFor let-time let-j="index" let-even="even" [ngForOf]="part">
          <Button text="{{ '\ue080' }}" [flexWrapBefore]="even"></Button>
          <Label  flexGrow="1" [text]="time"></Label>
        </ng-template>
      </FlexboxLayout>
    </GridLayout>
  </ng-template>
</Pager>

[mailiam]

It looks like PagerComponent constructor is not even called.
false alarm, itemTemplateQuery is empty
I will take a deeper look into the problem

[mailiam]

The problem lied on setItemTemplates that it is called when content is not yet initialized.

Calling setItemTemplates in ngAfterContentInit solved the issue.

NativeScritpt/nativescript-angular has refactored ListView to extend TemplatedItemsComponent

I suggest nativescript-pager can also benefit from extending TemplatedItemsComponent

@triniwiz what do you think?

[triniwiz]

@mailiam i've started https://github.com/triniwiz/nativescript-pager/tree/v9 you can test and lmk how things are running

[mailiam]

@mailiam i've started https://github.com/triniwiz/nativescript-pager/tree/v9 you can test and lmk how things are running

I should've looked into latest commits.
It works as expected!

[triniwiz]

@mailiam i'm exploring android.support.v4.app.FragmentStatePagerAdapter before I release v9 to see if I can squeeze some performance out

[mailiam]

Great! looking forward for v9 public release.
Thanks for awesome plugin.