Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy get_table_comment can return incorrect results or hang #217

Closed
dungdm93 opened this issue Aug 11, 2022 · 0 comments · Fixed by #218
Closed

SQLAlchemy get_table_comment can return incorrect results or hang #217

dungdm93 opened this issue Aug 11, 2022 · 0 comments · Fixed by #218

Comments

@dungdm93
Copy link
Member

There are 2 issue with current implementation of get_table_comment in SQLAlchemy dialect

  1. The query select from "system"."metadata"."table_comments" but not specify catalog_name that can lead to wrong result if Trino has 2 tables with the same name & schema but in different catalogs.
    image
  2. The query will be hang if one of the connector is not connected. Demo: I shutdown PostgreSQL and get comment of actor table in MySQL catalog.
    image
@dungdm93 dungdm93 mentioned this issue Aug 11, 2022
Merged
@hashhar hashhar changed the title get_table_comment issues SQLAlchemy get_table_comment can return incorrect results or hang Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify catalog_name in get_table_comment dungdm93/trino-python-client
1 participant
@dungdm93