Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource price and memo fee query interfaces for wallet-cli #666

Closed
lxcmyf opened this issue Sep 20, 2023 · 2 comments
Closed

Add resource price and memo fee query interfaces for wallet-cli #666

lxcmyf opened this issue Sep 20, 2023 · 2 comments

Comments

@lxcmyf
Copy link
Contributor

lxcmyf commented Sep 20, 2023

Rationale

In Java tron, there are already interfaces for resource unit price query/wallet/getbandwidthprices and/wallet/getenergyprices, as well as querying memo fee/wallet/getmemofee. These interfaces support HTTP and gRPC calls, but not wallet-cli. There, it is to add these APIs to wallet-cli so that make it convenient for developers to use.

Implementation

Due to the fact that wallet cli, as a client, interacts with TRON service through gRPC, simply add gRPC calls to /wallet/getbandwidthprices,/wallet/getenergyprices and /wallet/getmemofee.

@yuekun0707
Copy link

sounds great, I use wallet-cli all the time, glad to see the implementation~

@lxcmyf lxcmyf changed the title Add interfaces for querying resource unit prices and memo fee for wallet-cli Add resource price and memo fee query nterfaces for wallet-cli Sep 20, 2023
@lxcmyf lxcmyf changed the title Add resource price and memo fee query nterfaces for wallet-cli Add resource price and memo fee query interfaces for wallet-cli Sep 20, 2023
@halibobo1205
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants