Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java comment should be shown #749

Open
koppor opened this issue Jun 20, 2024 · 4 comments
Open

Added Java comment should be shown #749

koppor opened this issue Jun 20, 2024 · 4 comments

Comments

@koppor
Copy link

koppor commented Jun 20, 2024

Context: JabRef/jabref#11399

GitHub:

image

RefactoringMiner:

image

@tsantalis
Copy link
Owner

@koppor
Thank you for reporting this issue.

This is actually an inline comment, not Javadoc.

The reason I make this distinction is because the Eclipse JDT Parser we use, represent Javadoc as AST nodes, but inline comments are not represented as AST nodes.
This makes it impossible for us to show any changes for inline comments.

I will discuss with @pouryafard75 if there is any way to solve this issue.

@koppor koppor changed the title Added JavaDoc should be shown Added Java comment should be shown Jun 21, 2024
@tsantalis
Copy link
Owner

@koppor @pouryafard75
Once this PR get merged, we will be able to support inline comment diff.

@tsantalis
Copy link
Owner

@pouryafard75
PR merged.

@pouryafard75
Copy link
Contributor

@tsantalis
I beleive they have a CI pipeline for publishing to maven central. So as soon as new release get published in maven, we migrate to it. If they dont publish a new release, I will find a workaround for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants