Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange warning in recapitation #345

Open
trevorcousins opened this issue Jun 18, 2024 · 2 comments
Open

Strange warning in recapitation #345

trevorcousins opened this issue Jun 18, 2024 · 2 comments

Comments

@trevorcousins
Copy link

trevorcousins commented Jun 18, 2024

Hi, I am following the SLiM manual for recapitation, and after doing the command:

recap = pyslim.recapitate(ts, ancestral_Ne=ancestralNe, recombination_rate=recombinationrate)

I get the warning:
/home/trc468/.conda/envs/snakemake_new/lib/python3.10/site-packages/msprime/ancestry.py:831: TimeUnitsMismatchWarning: The initial_state has time_units=ticks but time is measured in generations in msprime. This may lead to significant discrepancies between the timescales.

Which I am a bit confused about - the SLiM manual indicates to me that ticks and generations are synonymous in a WF model (I did indeed simulate a WF model from SLiM). Is this just a safety warning?

@petrelharp
Copy link
Contributor

Yep, just a safety warning! For more info on this, see the docs.

I'll close this, but feel free to re-open if there's an issue here. I suppose one could make the case that in WF models SLiM should make the output time unit "generations" (or, ["ticks", "generations"]?), but this also sounds like a can of worms.

@bhaller
Copy link
Collaborator

bhaller commented Jun 19, 2024

Hey @petrelharp. I suggested that @trevorcousins ought to open this issue, because it seems weird to me that the warning is issued for WF models. If WF models ticks and generations are the same thing, so what, really, is pyslim warning about? And pyslim does know that the tree sequence came from a WF model, right? So, should it really warn in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants