From bfa714ae1e91e2f77017d02489cbc39fada032c7 Mon Sep 17 00:00:00 2001 From: Max Beatty Date: Thu, 4 Aug 2016 13:47:30 -0700 Subject: [PATCH] prevent navigating to area href when modal target. fixes #18796 --- js/src/modal.js | 2 +- js/tests/unit/modal.js | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/js/src/modal.js b/js/src/modal.js index 9b3a99ddd734..fd13a687cb40 100644 --- a/js/src/modal.js +++ b/js/src/modal.js @@ -491,7 +491,7 @@ const Modal = (($) => { let config = $(target).data(DATA_KEY) ? 'toggle' : $.extend({}, $(target).data(), $(this).data()) - if (this.tagName === 'A') { + if (this.tagName === 'A' || this.tagName === 'AREA') { event.preventDefault() } diff --git a/js/tests/unit/modal.js b/js/tests/unit/modal.js index 28c1e0ec7428..7329776bae0c 100644 --- a/js/tests/unit/modal.js +++ b/js/tests/unit/modal.js @@ -403,4 +403,26 @@ $(function () { }) .bootstrapModal('show') }) + + QUnit.test('should not follow link in area tag', function (assert) { + assert.expect(2) + var done = assert.async() + + $('') + .appendTo('#qunit-fixture') + + $('