Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootrap carousel (keyboard: false) and modal pop up do not mix well #20793

Closed
ugenegrg opened this issue Sep 27, 2016 · 2 comments
Closed

bootrap carousel (keyboard: false) and modal pop up do not mix well #20793

ugenegrg opened this issue Sep 27, 2016 · 2 comments

Comments

@ugenegrg
Copy link

ugenegrg commented Sep 27, 2016

All right, using data attribue or via js, it works, which is prevent keyboard leftarrow-prev/right-arrow-next , but there is an strange issue in my case.
I have disabled the key reaction in carousel which is working fine, but i have a popup in the lets's say 5th slide, and used the bootstrap modal for popup. Now the problem is when bootstrap modal is showing, the keyboard false does not prevent the carousel from sliding? Any help is appreciated. Also tried the solutions to prevent action using event listener and others as below.

window.addEventListener("keydown", function(e) { // space and arrow keys if([32, 37, 38, 39, 40].indexOf(e.keyCode) > -1) { e.preventDefault(); } }, false);

By the way my pop modal is outside of the the carousel. It is just triggered from one of the carousel slide.

@mdo
Copy link
Member

mdo commented Oct 28, 2016

This would be fixed by #20907 or #19058 I think.

@mdo
Copy link
Member

mdo commented Mar 19, 2017

Closing as referenced PRs were merged.

@mdo mdo closed this as completed Mar 19, 2017
@mdo mdo added this to the v4.0.0-beta milestone Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants