Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse.js Left & Right [Feature Req.] #21303

Closed
davebowker opened this issue Dec 5, 2016 · 3 comments
Closed

Collapse.js Left & Right [Feature Req.] #21303

davebowker opened this issue Dec 5, 2016 · 3 comments

Comments

@davebowker
Copy link

davebowker commented Dec 5, 2016

I'm currently working on an off canvas navigation and I'm trying to use BS as much as possible.

I implemented a nav as standard and just styled it to be like a sidebar. When applying collapse to it, as I would a top of page nav, the functionality works but collapse is setting height:0 and scrolling vertical. I can overcome a lot of this in CSS.

Feature Idea: Can we also collapse left/right with .collapse-h or .collapse-v and then we can do the rest in CSS?

Thanks

EDIT:
I see that you can add .width to dictate collapse direction, however it's not working 100% and is much worse when using flexbox.

@mdo mdo modified the milestone: v4.1 ideas Dec 27, 2016
@judetucker
Copy link

@davebowker check out #21540. Is this the desired functionality?

@davebowker
Copy link
Author

davebowker commented Jan 5, 2017

@judetucker Yup! Looks good, nice job, bud! :)

EDIT
This is what I was trying to do, but I still think that having the collapse.js be able to collapse both vertically and horizontally gives us the tools within the BS framework for us to create custom solutions.

@mdo
Copy link
Member

mdo commented Jul 2, 2017

Closing as dupe of #17496.

@mdo mdo closed this as completed Jul 2, 2017
@mdo mdo removed this from the v4.1 ideas milestone Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants