Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: url safe base64 validation #1013

Closed
korki43 opened this issue Apr 8, 2021 · 7 comments
Closed

feature: url safe base64 validation #1013

korki43 opened this issue Apr 8, 2021 · 7 comments
Labels
flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. status: fixed Issues with merged PRs, but not released yet. type: feature Issues related to new features.

Comments

@korki43
Copy link

korki43 commented Apr 8, 2021

Description

There should be a way to validate url safe base64.

Proposed solution

Add validator.IsBase64Options as optional constraints to the isBase64 decorator.
@korki43 korki43 added flag: needs discussion Issues which needs discussion before implementation. type: feature Issues related to new features. labels Apr 8, 2021
@mug-cat
Copy link

mug-cat commented Jul 14, 2022

Interesting how this is not getting any attention at all

@gustavotoyota
Copy link

Just bumped into this problem.

@braaar
Copy link
Member

braaar commented Sep 2, 2022

Seems like a no brainer, since this is just catching up to the upstream features.

Anyone want to make a PR?

@korki43
Copy link
Author

korki43 commented Sep 5, 2022

It seems like this repo was abandoned. The last non-automated commit was 10 months ago despite a lot of of open issues/PRs.

For now you can use patch-package to fix this by yourself.

@braaar
Copy link
Member

braaar commented Sep 6, 2022

It seems like this repo was abandoned. The last non-automated commit was 10 months ago despite a lot of of open issues/PRs.

For now you can use patch-package to fix this by yourself.

I have made this issue about the matter. Chime in if you're interested in trying to revive the project!

@braaar braaar mentioned this issue Oct 3, 2022
Closed
@NoNameProvided NoNameProvided added flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. and removed flag: needs discussion Issues which needs discussion before implementation. labels Dec 9, 2022
@NoNameProvided NoNameProvided mentioned this issue Dec 9, 2022
Merged
6 tasks
@NoNameProvided NoNameProvided added the status: fixed Issues with merged PRs, but not released yet. label Dec 9, 2022
@NoNameProvided
Copy link
Member

Fixed in #1845.

@korki43 korki43 closed this as completed Mar 26, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: BREAKING CHANGE Issues containing a breaking change, requiring a major release. status: fixed Issues with merged PRs, but not released yet. type: feature Issues related to new features.
Milestone
No milestone
Development

No branches or pull requests
5 participants
@NoNameProvided @braaar @gustavotoyota @mug-cat @korki43