Skip to content

Commit

Permalink
filter update
Browse files Browse the repository at this point in the history
  • Loading branch information
Yuki2718 committed Dec 7, 2023
1 parent 6ff24b5 commit 20312c2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions filters/filters.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ youtube.com##.ytlr-horizontal-list-renderer__items > .yt-virtual-list__container
youtube.com###player [class*="suggested-action-badge-icon"]:upward(.ytp-suggested-action)
! https://www.reddit.com/r/uBlockOrigin/comments/163cy47/youtube_antiadblock_and_ads_weekly_thread_august/jyemgzo/
||googlevideo.com/initplayback?source=youtube*&c=TVHTML5&oad=$xhr,domain=youtube.com
! https://github.com/uBlockOrigin/uBlock-discussions/discussions/831#discussioncomment-7758831
!#if env_firefox
||youtube.com/s/desktop/*/jsbin/desktop_polymer.vflset/desktop_polymer.js$urltransform=/desktop\/\w+\/jsbin/desktop\/1f2ae858\/jsbin/,domain=www.youtube.com
!#endif

! AdDefend
!#if env_chromium
Expand Down
4 changes: 4 additions & 0 deletions filters/quick-fixes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ youtube.com##+js(json-prune, playerResponse.adPlacements playerResponse.playerAd
youtube.com#@##merch-shelf
youtube.com#@##video-masthead
youtube.com#@##player-ads
! https://github.com/uBlockOrigin/uBlock-discussions/discussions/831#discussioncomment-7758831
!#if env_firefox
||youtube.com/s/desktop/*/jsbin/desktop_polymer.vflset/desktop_polymer.js$urltransform=/desktop\/\w+\/jsbin/desktop\/1f2ae858\/jsbin/,domain=www.youtube.com
!#endif

! https://github.com/uBlockOrigin/uAssets/issues/18476
! VOE sites
Expand Down

6 comments on commit 20312c2

@TheBSODAndWSODFan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/uBlockOrigin/uBlock-discussions/discussions/831#discussioncomment-7758831
404 Page Not Found

@Yuki2718
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessible only by uBO team members.

@AGlezB
Copy link

@AGlezB AGlezB commented on 20312c2 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke youtube on Firefox for me. I had to disable the rule to get it working again.

image

@fusenuk
Copy link

@fusenuk fusenuk commented on 20312c2 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line looks to be 'urltransform' isn't using the correct syntax based on the other two examples of using urltransform to do regex replacements - https://github.com/search?q=repo%3AuBlockOrigin%2FuAssets%20urltransform&type=code

@gorhill
Copy link
Member

@gorhill gorhill commented on 20312c2 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted for the time being.

@krystian3w
Copy link
Contributor

@krystian3w krystian3w commented on 20312c2 Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe possible import as uritransform without hard update e.g. nothing can changed by YouTube like commit tag 1f2ae858.

Please sign in to comment.