-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have linter skip checking pre-parsing directives returning false in uBO #2964
Labels
enhancement
New feature or request
Comments
Real case by newbies: olegwukr/polish-privacy-filters#146 |
DandelionSprout
changed the title
Make the resource viewer's error checker discard entries that are inside "!#if !ext_ublock" and "!#if false" sections
Make the resource viewer's error checker not check entries that are inside "!#if !ext_ublock" and "!#if false" sections
Nov 18, 2023
It should skip checking all pre-parsing directives that return |
u-RraaLL
changed the title
Make the resource viewer's error checker not check entries that are inside "!#if !ext_ublock" and "!#if false" sections
Have linter skip checking pre-parsing directives returning false in uBO
Dec 23, 2023
IMO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
I tried to reproduce the issue when...
Description
While I love that the list syntax error checker has been available in regular resource viewing (Previously it was only in specific configurations of the logger), and that it has made my list-work easier, I've noticed one thing that is making it more tricky to find genuine syntax errors in some of my larger lists.
Using https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Dandelion%20Sprout's%20Anti-Malware%20List.txt as the example list for this report, the logger shows 65 errors as of 17th of November 2023, but all of them are packed inside
!#if
sections that indicate that those entries weren't intended for uBO in the first place. I fairly often use!#if !ext_ublock
for AdGuard-only syntaxes (Mostly$network
and$app
), and!#if false
for ABP workarounds.As such, having the error counter not include entries that are in those 2 types of sections, would've been splendid stuff.
A specific URL where the issue occurs.
chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/asset-viewer.html?url=https%3A%2F%2Fraw.githubusercontent.com%2FDandelionSprout%2Fadfilt%2Fmaster%2FDandelion%2520Sprout%27s%2520Anti-Malware%2520List.txt
Steps to Reproduce
!#if
sections.Expected behavior
That the error checker doesn't include entries in its count that are inside
!#if !ext_ublock
and!#if false
sections.Actual behavior
The error checker doesn't check for
!#if
or!#endif
, making it slightly harder and more crowded to look for actually incorrect syntaxes and misspellings.uBO version
1.53.0
Browser name and version
Chrome 119.0.6045.125 x64
Operating System and version
Windows 11 23H2 x64
The text was updated successfully, but these errors were encountered: