-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent cookie lists from being selected at the same time #3231
Comments
This kind of breakage can occur with any list that uses |
I wonder if uBO should discard a second filter trying to set the same cookie just as if it were an exact duplicate. |
There were actually other issues prior to the above case with 2 cookie lists conflicted to each other. I agree with the solution of only choosing 1 list for cookie. Other lists can use We don't encourage users to enable more lists to cover different sites any way, and all of the breakages will just be reported to uBO volunteers to solve. Breakage is always a more important issue than lack of sites' coverages. Reporting to respective list maintainers is the correct way to solve the latter. |
Agreed. In this particular case, though, the user had a custom AG Annoyance added to his lists (instead of enabled AG Cookie Notices itself), so the issue would've still arisen. |
Yes, I think we can just try to cover the most obvious/popular case here since it's impossible to cover all edge cases (even the same list can have same issue if there are some mistakes) |
This would make it difficult to diagnose filter issues since whichever one takes effect first is undetermined. |
The most conflicts are between |
In the past set-constant was similar breakage: #156 (comment) |
My proposal is to make it possible to select only one of them in the GUI. By "without having to remove either list from the extension", I meant "without having to remove them from the list of available lists" (in the other issue, someone hinted that you should remove the AdGuard list from uBlock Origin altogether). |
Prerequisites
I tried to reproduce the issue when...
Description
AdGuard/uBO – Cookie Notices
andEasyList/uBO – Cookie Notices
have filters that reload webpages after changing cookie values.If they're programmed to set cookies to different values, this may cause an infinite refresh loop.
Consider adding a check to prevent them from being selected at the same time. This would prevent conflicts without having to remove either list from the extension.
If a user has selected
EasyList/uBO – Cookie Notices
, and then click onAdGuard/uBO – Cookie Notices
, the extension will deselectEasyList/uBO – Cookie Notices
, and vice-versa.A specific URL where the issue occurs.
See https://github.com/uBlockOrigin/uAssets/issues/23562
Steps to Reproduce
Expected behavior
Actual behavior
uBO version
1.57.2
Browser name and version
Firefox 125.0.3
Operating System and version
Hannah Montana Linux
The text was updated successfully, but these errors were encountered: