Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rcpp dependencies #192

Open
dan-knight opened this issue Sep 6, 2024 · 0 comments · May be fixed by #193
Open

Update Rcpp dependencies #192

dan-knight opened this issue Sep 6, 2024 · 0 comments · May be fixed by #193
Assignees

Comments

@dan-knight
Copy link
Contributor

CRAN Message

Compilation fails with R_USE_STRICT_R_HEADERS=true, which defines
STRICT_R_HEADERS to 1 which removes

  • the legacy definition of PI (use POSIX's M_PI, available in R fer ever).
  • the RS.h declarations for Calloc, Realloc, Free (use R_ forms i
    available since R 3.4.0).

The aim is to clean the namespace: in particular having a definition
for Free has conflicted with some packages' C++ code.

It is planned that STRICT_R_HEADERS=1 will become the default for 4.5.0,
for which it would be good if all CRAN packages, and in particular the
ones with strong reverse dependencies, compile/install ok with the new
default.

Your package is among the ones with strong reverse dependencies which
need updating. We would thus really appreciate if you could provide a
new version of your package as soon as possible which checks ok with
STRICT_R_HEADERS=1.

You can verify that your package checks ok with STRICT_R_HEADERS=1 via R
CMD check --as-cran using a current version of R-devel.

Strict R Check Results

  • installing source package ‘BoutrosLab.plotting.general’ ...
    ** package ‘BoutrosLab.plotting.general’ successfully unpacked and MD5 sums checked
    ** using staged installation
    ** libs
    using C compiler: ‘gcc-14 (GCC) 14.2.0’
    make[1]: Entering directory '/data/gannet/ripley/R/packages/tests-Strict/BoutrosLab.plotting.general/src'
    gcc-14 -I"/data/gannet/ripley/R/R-devel/include" -DNDEBUG -I/usr/local/include -DSTRICT_R_HEADERS=1 -fpic -g -O2 -Wall -pedantic -mtune=native -Wp,-D_FORTIFY_SOURCE=3 -fexceptions -fstack-protector-strong -fstack-clash-protection -fcf-protection -Werror=implicit-function-declaration -Wstrict-prototypes -c distance.c -o distance.o
    gcc-14 -I"/data/gannet/ripley/R/R-devel/include" -DNDEBUG -I/usr/local/include -DSTRICT_R_HEADERS=1 -fpic -g -O2 -Wall -pedantic -mtune=native -Wp,-D_FORTIFY_SOURCE=3 -fexceptions -fstack-protector-strong -fstack-clash-protection -fcf-protection -Werror=implicit-function-declaration -Wstrict-prototypes -c init.c -o init.o
    gcc-14 -I"/data/gannet/ripley/R/R-devel/include" -DNDEBUG -I/usr/local/include -DSTRICT_R_HEADERS=1 -fpic -g -O2 -Wall -pedantic -mtune=native -Wp,-D_FORTIFY_SOURCE=3 -fexceptions -fstack-protector-strong -fstack-clash-protection -fcf-protection -Werror=implicit-function-declaration -Wstrict-prototypes -c ks.c -o ks.o
    ks.c: In function 'K':
    ks.c:151:18: error: implicit declaration of function 'Calloc'; did you mean 'calloc'? [-Wimplicit-function-declaration]
    151 | H = (double*) Calloc(m * m, double);
    | ^~~~~~
    | calloc
    ks.c:151:32: error: expected expression before 'double'
    151 | H = (double*) Calloc(m * m, double);
    | ^~~~~~
    ks.c:152:32: error: expected expression before 'double'
    152 | Q = (double*) Calloc(m * m, double);
    | ^~~~~~
    ks.c:180:4: error: implicit declaration of function 'Free'; did you mean 'free'? [-Wimplicit-function-declaration]
    180 | Free(H);
    | ^~~~
    | free
    ks.c: In function 'm_power':
    ks.c:218:33: error: expected expression before 'double'
    218 | B = (double*) Calloc(m * m, double);
    | ^~~~~~
    make[1]: *** [/data/gannet/ripley/R/R-devel/etc/Makeconf:195: ks.o] Error 1
    make[1]: Leaving directory '/data/gannet/ripley/R/packages/tests-Strict/BoutrosLab.plotting.general/src'
    ERROR: compilation failed for package ‘BoutrosLab.plotting.general’
  • removing ‘/data/gannet/ripley/R/packages/tests-strict/Libs/BoutrosLab.plotting.general-lib/BoutrosLab.plotting.general’
    Command exited with non-zero status 1
    Time 0:02.89, 1.21 + 0.28
@dan-knight dan-knight self-assigned this Sep 6, 2024
@dan-knight dan-knight linked a pull request Sep 6, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant