Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: random (hashed) room name #70

Open
datenbank-projekt opened this issue Feb 10, 2021 · 1 comment
Open

suggestion: random (hashed) room name #70

datenbank-projekt opened this issue Feb 10, 2021 · 1 comment

Comments

@datenbank-projekt
Copy link

Hi,

just a suggestion:
Maybe it would be better (suggestion) to have some random room name? Maybe a hash of username and domain? This would make collisions more unlikely.

Olaf

@datenbank-projekt
Copy link
Author

Hi,
I suggest using a MD5 hash from the avatar variable. This should make private rooms pretty private.
The changes that need to be done:
In sessionpriv.php
change
echo "roomName: \"".urlencode($sessionnorm)."\",\n";
to
echo "roomName: \"".md5($avatar)."\",\n";
and change
"room" => urlencode($sessionnorm),
to
"room" => md5($avatar),

Olaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant