Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: always show (blank) security parameters in private sessions #71

Open
datenbank-projekt opened this issue Feb 10, 2021 · 2 comments

Comments

@datenbank-projekt
Copy link

Hi,

just a suggestion:
Maybe in private sessions the user should always be able to set the security parameters himself: When I as admin disable jitsi_securitybutton, the user has no way to set anything. In private sessions probably a) the "domain" passwort set by the admin should not be shown b) the user should be able to set one.

Olaf

@datenbank-projekt
Copy link
Author

Hi,

quick fix
Open file sessionpriv.php
change
$security = ''; if ($CFG->jitsi_securitybutton == 1) { $security = 'security'; }

to
$security = 'security';

Of course using a setting of this mod would be nicer.
Olaf

@datenbank-projekt
Copy link
Author

Hi,

to prevent showing the domain jitsy password, the admin set, we can fix this by changing two lines in sessionpriv.php
change
echo " api.executeCommand('password', '".$CFG->jitsi_password."');";
to
echo " api.executeCommand('password', '".time()."');";
and change
echo " api.executeCommand('password', '".$CFG->jitsi_password."');";
to
echo " api.executeCommand('password', '".time()."');";

Which will return a timestamp as password, making sure probably noone will accidently enter the session, but the passwort can easily be transferred to someone else.
Olaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant