Cannot run model with URL as argument

[ju-w]

Hello,

Bug

#2194 broke model.forward() with URLs as argument and subsequently the Colab example https://colab.research.google.com/github/pytorch/pytorch.github.io/blob/master/assets/hub/ultralytics_yolov5.ipynb

Reproduce

e.g. run Colab example.

Trace

ValueError                                Traceback (most recent call last)
<ipython-input-1-86a3d667ec69> in <module>()
      9 
     10 # Inference
---> 11 results = model(imgs)
     12 
     13 # Results

2 frames
/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py in _call_impl(self, *input, **kwargs)
    725             result = self._slow_forward(*input, **kwargs)
    726         else:
--> 727             result = self.forward(*input, **kwargs)
    728         for hook in itertools.chain(
    729                 _global_forward_hooks.values(),

/root/.cache/torch/hub/ultralytics_yolov5_master/models/common.py in forward(self, imgs, size, augment, profile)
    201             if isinstance(im, str):  # filename or uri
    202                 im = Image.open(requests.get(im, stream=True).raw if im.startswith('http') else im)  # open
--> 203             files.append(Path(im.filename).with_suffix('.jpg').name if isinstance(im, Image.Image) else f'image{i}.jpg')
    204             im = np.array(im)  # to numpy
    205             if im.shape[0] < 5:  # image in CHW

/usr/lib/python3.6/pathlib.py in with_suffix(self, suffix)
    835         name = self.name
    836         if not name:
--> 837             raise ValueError("%r has an empty name" % (self,))
    838         old_suffix = self.suffix
    839         if not old_suffix:

ValueError: PosixPath('.') has an empty name

Reason

yolov5/models/common.py

Lines 201 to 203 in d2e754b

	if isinstance(im, str): # filename or uri
	im = Image.open(requests.get(im, stream=True).raw if im.startswith('http') else im) # open
	files.append(Path(im.filename).with_suffix('.jpg').name if isinstance(im, Image.Image) else f'image{i}.jpg')

An Image created from requests.get download will not have im.filename property set, thus Path(im.filename) will fail.

[github-actions]

👋 Hello @ju-w, thank you for your interest in 🚀 YOLOv5! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://www.ultralytics.com or email Glenn Jocher at glenn.jocher@ultralytics.com.

Requirements

Python 3.8 or later with all requirements.txt dependencies installed, including torch>=1.7. To install run:

$ pip install -r requirements.txt

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

• Google Colab and Kaggle notebooks with free GPU:
• Google Cloud Deep Learning VM. See GCP Quickstart Guide
• Amazon Deep Learning AMI. See AWS Quickstart Guide
• Docker Image. See Docker Quickstart Guide

Status

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), testing (test.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

[smartinellimarco]

I faced the same issue just now. Just wrote a dummy filename into the image's property.
Thanks for sharing!

[glenn-jocher]

@ju-w @MarcoCBA thanks for the bug report! Can you provide a minimum reproducible example please?
https://docs.ultralytics.com/help/minimum_reproducible_example/

[glenn-jocher]

Update, I can reproduce using the default Hub example at https://pytorch.org/hub/ultralytics_yolov5/

Will investigate, this should be working correctly but is not.

[glenn-jocher]

@ju-w @MarcoCBA this issue is fixed now in #2250. Please retry using the force_reload=True option when loading a new PyTorch Hub model.

Fix verified in Colab.

[glenn-jocher]

Removed TODO as original issue is resolved in #2250.